-
Notifications
You must be signed in to change notification settings - Fork 3k
Reproducer for issue for double quotes in kafka companion channel names #51312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc @radcortez @gsmet |
|
@mocenas 👋 the test is failing and requires a fix or it's all fine? |
That's weird it passes for me no problem, executing in using What failure do you have with it? |
f809237 to
ad86b8e
Compare
|
I rebased the PR on up-to-date main. |
This comment has been minimized.
This comment has been minimized.
ad86b8e to
44de84c
Compare
|
@mocenas it was a question :). But I think you answered it and it's all fine. Basically I wanted to know if it was a reproducer for an issue to fix or an additional test. I understand it's an additional test. |
This comment has been minimized.
This comment has been minimized.
44de84c to
f2d10b2
Compare
|
I decided to put this test into separate module in the end. When I tried to add it into existing integration-tests in just kept breaking stuff. E.g. The module I tried to put it in originally |
|
Can you please update the title of the PR, as it currently requires someone looking at the issue to figure out even the basic context |
This comment has been minimized.
This comment has been minimized.
|
I'll let @ozangunalp decide how he wants to handle this, but bear in mind a couple things:
|
|
I agree that we can add a test like this. Probably we also need to add one with the usage of We can add this test to an existing test module with more descriptive bean & test names such as |
f2d10b2 to
2a1c612
Compare
|
OK, I renamed the classes and moved the reproducer into |
Adding a tests for #50751 where KafkaCompanionResource got double-quoted channel name.
These tests are used in QE TS, but might also be useful here.